-
Couldn't load subscription status.
- Fork 0
feat: support HTTP forward proxy #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds HTTP forward proxy support to the Cosmian CLI, enabling connection through proxy servers with authentication capabilities. The implementation includes comprehensive proxy configuration options and integrates testing infrastructure to validate proxy functionality.
- Adds proxy configuration support with authentication methods (basic auth and custom headers)
- Consolidates certificate validation flags into a single
--accept-invalid-certsoption - Updates submodules for KMS and Findex server components to support proxy features
Reviewed Changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| kms | Updates KMS submodule to include proxy support functionality |
| findex-server | Updates Findex server submodule for proxy compatibility |
| documentation/docs/cli/main_commands.md | Documents new proxy-related CLI options and consolidates cert validation flags |
| docker-compose.yml | Adds Squid proxy container for testing proxy functionality |
| crate/cli/src/tests/kms/version.rs | Adds integration test for proxy functionality using server version endpoint |
| crate/cli/src/tests/kms/mod.rs | Registers new version test module |
| crate/cli/src/tests/kms/auth_tests.rs | Adds clippy allow annotation for large stack frames |
| crate/cli/src/proxy_config.rs | Implements ProxyConfig struct with all proxy configuration options |
| crate/cli/src/lib.rs | Exports the new proxy_config module |
| crate/cli/src/commands.rs | Integrates proxy configuration into CLI and client setup |
| Cargo.toml | Removes unused cosmian_http_client dependency |
| .github/scripts/squid/squid.conf | Squid proxy configuration for testing with basic authentication |
| .github/scripts/squid/passwd | Password file for Squid proxy authentication |
528c211 to
bbc1851
Compare
No description provided.