Skip to content

Conversation

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a Google Key Management Service (KMS) key pair creation feature in the Cosmian CLI, adding the ability to create and manage Google CSE (Client-Side Encryption) key pairs for Gmail integration.

Key changes include:

  • Adds new CLI commands for Google KMS key pair operations
  • Implements comprehensive test coverage for key pair creation workflows
  • Updates documentation with detailed parameter descriptions and examples
  • Updates submodule dependencies to support the new functionality

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test_data, kms, findex-server Updated submodule commits to include latest Google KMS features
documentation/docs/cli/main_commands.md Added comprehensive documentation for Google key pair creation parameters and examples
crate/cli/src/tests/kms/utils/extract_uids.rs Added utility function to extract certificate IDs from command output
crate/cli/src/tests/kms/symmetric/create_key.rs Changed test function visibility from public to private
crate/cli/src/tests/kms/google_cmd/mod.rs Reorganized Google command test modules and enabled key pair tests
crate/cli/src/tests/kms/google_cmd/keypairs_enabling.rs Added comprehensive tests for key pair enabling/disabling operations
crate/cli/src/tests/kms/google_cmd/keypairs.rs Completely rewritten to test key pair creation with various certificate options
Cargo.toml Updated KMS CLI and test server versions to 5.6.2
.pre-commit-config.yaml Updated git hooks version and made cargo-deny manual
Comments suppressed due to low confidence (1)

crate/cli/src/tests/kms/google_cmd/keypairs_enabling.rs:1

  • The constant KMS_SUBCOMMAND is used on line 58 but is not defined in this file. This will cause a compilation error.
use std::process::Command;

@Manuthor Manuthor merged commit e2815c6 into develop Aug 20, 2025
12 checks passed
@Manuthor Manuthor deleted the feat/support_pkcs12_in_google_key_pair_generation branch August 20, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants