Skip to content

Conversation

digantamisra98
Copy link
Collaborator

Fixing some errors with the current artifacts integration.

@digantamisra98 digantamisra98 marked this pull request as draft July 25, 2021 19:57
@coveralls
Copy link

coveralls commented Jul 25, 2021

Pull Request Test Coverage Report for Build 1080820141

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 82.114%

Changes Missing Coverage Covered Lines Changed/Added Lines %
avalanche/evaluation/metrics/checkpoint.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
avalanche/benchmarks/scenarios/generic_definitions.py 2 85.37%
Totals Coverage Status
Change from base Build 1075424779: -0.02%
Covered Lines: 10357
Relevant Lines: 12613

💛 - Coveralls

@digantamisra98
Copy link
Collaborator Author

It seems that the copy.deepcopy(list(strategy.model.parameters())) does work but returns the params as a list cloned from the source generator object in the evaluation/metrics/checkpoint.py which when used in logging/wandb_logger.py doesn't seem to pass through the if isinstance(value, Tensor): line since it demands a Tensor while the metric returns a List.

@ContinualAI-bot
Copy link
Collaborator

Oh no! It seems there are some PEP8 errors! 😕
Don't worry, you can fix them! 💪
Here's a report about the errors and where you can find them:

avalanche/logging/wandb_logger.py:122:81: E501 line too long (83 > 80 characters)
avalanche/logging/wandb_logger.py:145:49: E128 continuation line under-indented for visual indent
avalanche/logging/wandb_logger.py:146:49: E128 continuation line under-indented for visual indent
avalanche/logging/wandb_logger.py:149:37: E128 continuation line under-indented for visual indent
avalanche/logging/wandb_logger.py:169:1: E303 too many blank lines (3)
3       E128 continuation line under-indented for visual indent
1       E303 too many blank lines (3)
1       E501 line too long (83 > 80 characters)

@ContinualAI-bot
Copy link
Collaborator

Oh no! It seems there are some PEP8 errors! 😕
Don't worry, you can fix them! 💪
Here's a report about the errors and where you can find them:

avalanche/logging/wandb_logger.py:122:81: E501 line too long (83 > 80 characters)
avalanche/logging/wandb_logger.py:145:49: E128 continuation line under-indented for visual indent
avalanche/logging/wandb_logger.py:146:49: E128 continuation line under-indented for visual indent
avalanche/logging/wandb_logger.py:149:37: E128 continuation line under-indented for visual indent
avalanche/logging/wandb_logger.py:169:1: E303 too many blank lines (3)
3       E128 continuation line under-indented for visual indent
1       E303 too many blank lines (3)
1       E501 line too long (83 > 80 characters)

@ContinualAI-bot
Copy link
Collaborator

Oh no! It seems there are some PEP8 errors! 😕
Don't worry, you can fix them! 💪
Here's a report about the errors and where you can find them:

avalanche/logging/wandb_logger.py:122:81: E501 line too long (83 > 80 characters)
avalanche/logging/wandb_logger.py:145:49: E128 continuation line under-indented for visual indent
avalanche/logging/wandb_logger.py:146:49: E128 continuation line under-indented for visual indent
avalanche/logging/wandb_logger.py:149:37: E128 continuation line under-indented for visual indent
avalanche/logging/wandb_logger.py:169:1: E303 too many blank lines (3)
3       E128 continuation line under-indented for visual indent
1       E303 too many blank lines (3)
1       E501 line too long (83 > 80 characters)

@AndreaCossu
Copy link
Collaborator

@digantamisra98 any news on this?

@digantamisra98
Copy link
Collaborator Author

@AndreaCossu I am no longer at W&B. But I am happy to finish this but won't be able to before December. Thanks!

lrzpellegrini added a commit to lrzpellegrini/avalanche that referenced this pull request Jun 7, 2023
@lrzpellegrini
Copy link
Collaborator

Added in #1463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants