-
Notifications
You must be signed in to change notification settings - Fork 88
EIP-4844 signing support #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
EIP-4844 signing support #1096
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
…_of_eip_4844_transactions
…kows/web3signer into signing_of_eip_4844_transactions
Signed-off-by: Maciej Skrzypkowski <[email protected]>
Signed-off-by: Maciej Skrzypkowski <[email protected]>
Signed-off-by: Maciej Skrzypkowski <[email protected]>
…nJsonParametersTest Signed-off-by: Maciej Skrzypkowski <[email protected]>
I'm still waiting for the web3j PR to be merged (LFDT-web3j/web3j#2196), but could you please check if I've missed anything in this PR? Tests have been added. |
Hello, we're adding support for Web3Signer to the Aztec node and would like to be able to sign EIP-4844 txs through its API. Any chance someone could take a look at this PR? Thanks :) |
@alexghr @mskrzypkows I've started reviewing it, will update here (and on Discord). Most likely, I will create a patch for @mskrzypkows to apply on his PR. |
@mskrzypkows LFDT-web3j/web3j#2196 seems to be approved, I am not sure when it will be merged. |
@mskrzypkows do you have a failing test case for mismatched "from'? |
@usmansaleem What do you mean? Mismatched after recovering |
@mskrzypkows Yes, the PR description mentions that "from" is mismatch, how can I reproduce this behaviour? |
Ah, the description is outdated. So the wrong |
Signed-off-by: Maciej Skrzypkowski <[email protected]>
The web3j PR has been merged. There is no release yet, while waiting for it, I have added a snapshot version so it can be tested easier. |
...ava/tech/pegasys/web3signer/core/service/jsonrpc/handlers/signing/TransactionSerializer.java
Outdated
Show resolved
Hide resolved
@usmansaleem fixed, web3j 5.0.1 has been released, added usage of new version. |
@mskrzypkows Can you add a changelog entry please (in CHANGELOG.md file). |
…uding EIP-4844 transaction signing support and web3j library upgrade to 5.0.1. Signed-off-by: Maciej Skrzypkowski <[email protected]>
@usmansaleem updated |
Any updates on this? I'm wondering if this PR will have to be updated to support the post-Fusaka blob format (using cell proofs instead of blob proofs). The new format requires a new byte 0x01 to be inserted between the tx body and the blobs |
I want to add EIP-4844 support. This signs now, but I have some mismatch of the
from
address when I dosend_raw_transaction
of the signed transaction (the nonce is not correct that's why I guess the address is wrong). Do you have some suggestions what's missing?Note
Adds EIP-4844 blob transaction signing (params, creation, serialization) with tests, and upgrades web3j to 5.0.1.
EthSendTransactionJsonParameters
withmaxFeePerBlobGas
,blobVersionedHashes
, andblobs
(+ setters/getters).isEip4844()
inEthTransaction
; build 4844 transactions from rawblobs
orblobVersionedHashes
(via web3jRawTransaction.createTransaction
), with logging.Transaction
interface to includeisEip4844()
.TransactionSerializer
(type prefixing and signing flow).EthSendTransactionJsonParametersTest
,EthSignTransactionResultProviderTest
, andEthTransactionTest
.org.web3j
to5.0.1
.Written by Cursor Bugbot for commit 7d1a14b. This will update automatically on new commits. Configure here.