-
Notifications
You must be signed in to change notification settings - Fork 0
Support lts-20.4.
#3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
36ce419 to
af31488
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
I'm not quite sure I understand why the cabal files are changed? Is that due to bumping the ghc version?
| cabal-version: 1.12 | ||
|
|
||
| -- This file has been generated from package.yaml by hpack version 0.33.0. | ||
| -- This file has been generated from package.yaml by hpack version 0.35.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change related to the ghc bump?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stack @ 2.9.1 bumps hpack to 0.35, and to my understanding this is the version supported by lts-20.4, see https://www.stackage.org/lts-20.4. Is this change problematic?
| cabal-version: 1.12 | ||
|
|
||
| -- This file has been generated from package.yaml by hpack version 0.31.2. | ||
| -- This file has been generated from package.yaml by hpack version 0.35.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above.
Purpose
Upgrade to support stackage snapshot to
lts-20.4.Changes
stack.yamltolts-20.4.proto3-wireto 1.4.0.http2-clientto one that is updated to supportlts-20.4.Dependencies
Concordium/http2-client#3
Checklist
hard-to-understand areas.