Skip to content

Conversation

@vikt0r0
Copy link

@vikt0r0 vikt0r0 commented Dec 14, 2022

Purpose

Upgrade to support stackage snapshot to lts-20.4.

Changes

  • Bump resolver in stack.yaml to lts-20.4.
  • Update dependency of proto3-wire to 1.4.0.
  • Update dependency on http2-client to one that is updated to support lts-20.4.

Dependencies

Concordium/http2-client#3

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

Copy link

@MilkywayPirate MilkywayPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
I'm not quite sure I understand why the cabal files are changed? Is that due to bumping the ghc version?

cabal-version: 1.12

-- This file has been generated from package.yaml by hpack version 0.33.0.
-- This file has been generated from package.yaml by hpack version 0.35.0.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change related to the ghc bump?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack @ 2.9.1 bumps hpack to 0.35, and to my understanding this is the version supported by lts-20.4, see https://www.stackage.org/lts-20.4. Is this change problematic?

cabal-version: 1.12

-- This file has been generated from package.yaml by hpack version 0.31.2.
-- This file has been generated from package.yaml by hpack version 0.35.0.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above.

@vikt0r0 vikt0r0 merged commit 7f4f495 into conn-window-updates Jan 2, 2023
@vikt0r0 vikt0r0 deleted the vh/upgrade-tooling branch April 1, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants