Skip to content

Add trimming support #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 31, 2021
Merged

Add trimming support #76

merged 11 commits into from
Dec 31, 2021

Conversation

Sergio0694
Copy link
Member

@Sergio0694 Sergio0694 commented Dec 31, 2021 •
edited
Loading

Contributes to #8
Closes #39

This PR adds trimming support to all libraries.
It also includes trimming annotations where needed.

Additionally, it enables implementing OnActivated/OnDeactivated with [ObservableRecipient], which was missing.

@Sergio0694 Sergio0694 added feature 💡 A new feature being implemented improvements ✨ Improvements to an existing functionality next preview ✈️ This changes will be available in the upcoming preview optimization ☄ Performance or memory usage improvements priority 🚩 An issue or change that has priority labels Dec 31, 2021
@Sergio0694 Sergio0694 merged commit f7a980e into main Dec 31, 2021
@delete-merged-branch delete-merged-branch bot deleted the dev/trimming-support branch December 31, 2021 19:09
XAML-Knight
XAML-Knight reviewed Jan 3, 2022
View reviewed changes
Copy link

@XAML-Knight XAML-Knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR was already merged into the main branch, but came across an issue in one of the unit tests, as well as a misspelling

tests/CommunityToolkit.Mvvm.Internals.UnitTests/Test_Messenger.cs

messenger.UnregisterAll(recipientB);

Assert.IsFalse(messenger.IsRegistered<MessageB>(recipientA));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assert.IsFalse(messenger.IsRegistered<MessageA>(recipientB));

tests/CommunityToolkit.Mvvm.Internals.UnitTests/Test_Messenger.cs
}

// We also add the ICloneable interface to test that the message
// interfaces are all handled correctly even when inteleaved
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interleaved (sp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

+1 more reviewer

@XAML-Knight XAML-Knight XAML-Knight left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
feature 💡 A new feature being implemented improvements ✨ Improvements to an existing functionality next preview ✈️ This changes will be available in the upcoming preview optimization ☄ Performance or memory usage improvements priority 🚩 An issue or change that has priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add trimming support for all packages
3 participants
@Sergio0694 @Arlodotexe @XAML-Knight