Skip to content

Conversation

Kyaa-dost
Copy link
Collaborator

Fixes #7

What changes does this PR introduce?

Introduces App Gallery In Home

PR Checklist

Please check if your PR fulfills the following requirements:

  • Correctly picked the forked new branch to base the change off (main)
  • Ran against a spell and grammar checker

Other information

Copy link
Contributor

@Rosuavio Rosuavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we can use some more links to the individual projects.

@michael-hawker michael-hawker marked this pull request as draft May 19, 2021 20:57
@ghost
Copy link

ghost commented May 26, 2021

Kyaa-dost This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Home.md Outdated
Console/IDE: is a fully featured console and IDE/debugger for an obscure programming language.

**In the words of Sergio**:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be consistent about how we quote the creators for each app. So we should be like:

### [App Name](Link to store) by [Creator](Link to GitHub Profile)
(Image) + link to Store/GitHub
App Description
> "Quote from Developer" - _Developer Name_
Toolkit Components Used: MVVM Toolkit, WrapPanel, etc...
[GitHub](link) - [Store](link)

Kyaa-dost and others added 4 commits June 15, 2021 13:20
Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
Home.md Outdated

### [Fiona](https://www.mysqueezebox.com/download) by [PaoloM](https://github.com/PaoloM)

![Fiona1](https://github.com/Kyaa-dost/WindowsCommunityToolkit-wiki/blob/App-Gallery/images/Fiona1.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's clean-up the images below in the image folder as a sub-folder, and for only the one's we're using (images/app-gallery), then we can reference them relatively like:

![Expanded PR Checks with Build Number](images/Preview-Packages-PR-Checks.png)

Let's stick with pngs or jpgs vs large gifs as we don't want a ton of images in the git repo.

@michael-hawker michael-hawker marked this pull request as ready for review June 22, 2021 21:21
@michael-hawker michael-hawker merged commit 6ac7e47 into CommunityToolkit:main Jun 22, 2021
@Kyaa-dost Kyaa-dost deleted the App-Gallery branch June 24, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Page on the 'App Gallery'
4 participants