Refactor TextCaseConverter and enhance ListToStringConverterTests #2840
+9
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds missing unit test coverage for the
ListToStringConverterwhen handling whitespace-only strings.The
ListToStringConvertercorrectly filters out strings that are null, empty, or contain only whitespace characters (as implemented in line 40 of the converter), but there were no unit tests verifying this behavior for whitespace-only strings like spaces, tabs, and newlines.Changes:
Test Cases Added:
["A", " ", "C"]→"A,C"(spaces)["A", "\t", "C"]→"A,C"(tabs)["A", "\n", "C"]→"A,C"(newlines)Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposalmainat time of PRAdditional information
Platforms tested: N/A (unit tests only)
Type of change: Test coverage improvement
Impact: Low risk - only adds unit tests, no functional changes