Skip to content

Fix 'advenure' typos #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 10, 2023
Merged

Fix 'advenure' typos #499

merged 3 commits into from
Dec 10, 2023

Conversation

@dkim19375
Copy link
Contributor

Not sure if I need to put since = "..."

@JorelAli JorelAli changed the base branch from master to dev/dev October 19, 2023 23:14
@JorelAli
Copy link
Member

I think it's worth putting since = "9.3.0", even if it's not a major change and is going to be removed, it's good for future developers that are maintaining this software (knowing when something was deprecated helps give an idea when to remove it), as well as developers using the CommandAPI (knowing when it was made known that this is a dodgy method name)

@JorelAli JorelAli merged commit 23e3bf1 into CommandAPI:dev/dev Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JorelAli JorelAli JorelAli requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkim19375 @JorelAli