Align seeCheckboxIsChecked() and dontSeeCheckboxIsChecked() parameter types #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Released as 3.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed an inconsistency whilst trying to upgrade to 5.0.0-RC2.
Both the
seeCheckboxIsChecked()anddontSeeCheckboxIsChecked()used to accept an array parameter (e.g.['css' => '.foobar']), butdontSeeCheckboxIsChecked()no longer does.I looked and it seems like there's nothing stopping both methods accepting the array formatted parameter, so I've removed the type on
dontSeeCheckboxIsChecked()and added some test coverage.I wasn't sure if lib-web also needed updating, but I can do that if necessary.