chore: Add parallel-lint to lint downgraded source #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbalandan
force-pushed
the
parallel-lint
branch
from
797f3d5 to
e54c1af
Compare
paulbalandan
force-pushed
the
parallel-lint
branch
from
e54c1af to
d5de5bd
Compare
kenjis
reviewed
Nov 17, 2023
| run: php bin/transform-source ${{ env.TARGET_PHP_VERSION_ID }} | ||
|
|
||
| - name: Run lint on src | ||
| run: vendor/bin/parallel-lint src --colors --show-deprecated |
There was a problem hiding this comment.
It seems you do not check on PHP 7.4. Is it intentional?
Collaborator
Author
There was a problem hiding this comment.
That's my original intention. But composer update fails: https://github.com/CodeIgniter/phpstan-codeigniter/actions/runs/6873219405/job/18692938215
If I will reinstall PHP for PHP 7.4, I will first remove PHPUnit 10 to run lint then reinstall again PHP 8.1 to run tests. It's tedious. Unless you have another flow in mind?
There was a problem hiding this comment.
Okay, frankly, I feel it is tedious to downgrade.
I want to drop PHP 7.4 and 8.0!
Collaborator
Author
There was a problem hiding this comment.
This downgrading is just a hack for now while v4.5 is not yet out.
kenjis
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to catch lint errors early on before releases.