add a retry to retrieve the CIRCLE_OIDC_TOKEN if it doesn't exist in … #221
Conversation
| echo "Successfully set CIRCLE_OIDC_TOKEN" | ||
| echo 'export CIRCLE_OIDC_TOKEN="'"$CIRCLE_OIDC_TOKEN"'"' >> "$BASH_ENV" | ||
| echo 'export CIRCLE_OIDC_TOKEN_V2="'"$CIRCLE_OIDC_TOKEN"'"' >> "$BASH_ENV" | ||
| exit 0 |
There was a problem hiding this comment.
Hi I was reviewing the script and was wondering why we would want to exit out of here? Wouldn't we want to exit the for loop and continue the script?
There was a problem hiding this comment.
Hi @ohjinsoo!
In this version of this script, if the exit 0 was not there, even if it were able to get a new token, it would trigger the last echo "failed to set ..." message.
The exit 0 in this case exits the scripts entirely once we confirm that we have a token set.
There was a problem hiding this comment.
Right, but the command aws-cli/setup is used to setup AWS creds. By exiting here, you won't be setting AWS creds, and you'd have to run the same command again which doesn't seem ideal.
There was a problem hiding this comment.
Good catch. I've created a new PR for this #224
3 participants
Checklist
Motivation, issues
Sometimes, the
CIRCLE_OIDC_TOKEN/V2is missing from a job.With the CircleCI CLI in jobs, you can configure a new token based on any audience.
This utilizes the built-in
CIRCLE_ORGANIZATION_IDenvironment variable as the audience, similar to the current token that's injected into your job.Description
Currently, the AWS CLI Orb errors out, which requires you to rerun the workflow.
This provides a retry mechanism to try 3 times to retrieve a new token based on the