feat: set_aws_env_vars #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 5, 2023
brivu
force-pushed
the
feat/configure_aws_env_vars
branch
from
0aaf8f5 to
17d5b68
Compare
EricRibeiro
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
assume_role_with_web_identitycommand generates temporary AWS keys that gets written to a temporary file, enabling users to create multiple profiles without having to alterBASH_ENV. This was helpful for users who ran workflows requiring multiple profiles to run theirawscommands.However, this change broke for many users (see #179) who were relying on the AWS key being written to
BASH_ENV.This pull request adds ads the
set_aws_env_varsparameter to theassume_role_with_web_identitycommand that enables to write the keys to a temporary file when set tofalse. Otherwise, it automatically writes toBASH_ENVby default.