Skip to content

fix: edit grep to check first two characters #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix: edit grep to check first two characters #181

merged 1 commit into from
Dec 6, 2023

Conversation

@brivu
Copy link
Contributor

@brivu brivu commented Nov 29, 2023

Currently, the grep statement in the windows install script checks for 2., which is intended to check for version 2 of the aws cli. However, the install fails because any version string containing 2. like 1.2.3 validate the grep statement.

This PR edits the statement to check for 2. in the first two characters of the version string.

@brivu brivu self-assigned this Nov 29, 2023
@brivu brivu requested a review from a team as a code owner November 29, 2023 23:02
@brivu brivu changed the title fix: edit grep fix: edit grep to check first two characters Nov 29, 2023
@brivu brivu linked an issue Nov 29, 2023 that may be closed by this pull request
Grep statement in install.sh (Windows) can cause wrong path to be added #175
Closed
@brivu brivu merged commit 256a96f into master Dec 6, 2023
@brivu brivu deleted the fix/windows-install-script branch December 6, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@EricRibeiro EricRibeiro EricRibeiro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@brivu brivu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Grep statement in install.sh (Windows) can cause wrong path to be added

3 participants

@brivu @EricRibeiro