Skip to content

Fix hyper diffusion equation solver_showcase_1d.ipynb #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix hyper diffusion equation solver_showcase_1d.ipynb #69

wants to merge 1 commit into from

Conversation

@qiauil
Copy link
Contributor

@qiauil qiauil commented Jun 30, 2025

No description provided.

@Ceyron Ceyron mentioned this pull request Oct 28, 2025
Merged
@Ceyron
Copy link
Owner

Ceyron commented Oct 28, 2025

Hi @qiauil,
Thanks for noting this, and sorry for the late reply.
I think it is a question of definition. I chose to have a negative sign here such that the coefficient of hyper-diffusion is positive (which I thought to be more intuitive). It also matches the form I chose for the APEBench paper on page 31.
But you raised a fair point, and I guess the documentation on top of this page, corresponding to this (permalink) doc file has to be adapted.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qiauil @Ceyron