Skip to content

Conversation

@Algunenano
Copy link
Contributor

  • Test PG12 with bionic.
  • Always use @@plpythonu@@ to clearly mark it as a variable.
  • Reduce the log level of _CDB_LinkGhostTables from notice to log.
  • Test CDB_LinkGhostTables independently of the node-redis version (different versions had different error messages).

@Algunenano Algunenano self-assigned this Dec 26, 2019
@Algunenano Algunenano merged commit 741d171 into CartoDB:master Dec 26, 2019

PERFORM @extschema@._CDB_LinkGhostTables(username, db_name, event_name);
RAISE NOTICE '_CDB_LinkGhostTables() called with username=%, event_name=%', username, event_name;
RAISE INFO '_CDB_LinkGhostTables() called with username=%, event_name=%', username, event_name;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

@rafatower
Copy link
Contributor

Please, anything going to master should go through peer review 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants