use literal substitution instead of identifier #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Fine by me, but most likely the problem comes from double quoting, that is, changes in the parameter passed to the function (I can tell for sure this used to work ok under different conditions). |
Contributor
Author
|
This is how it's being called from cartodb (which is the origin of the issue): I did some manual tests and it seems to happen when the database_schema contains |
Algunenano
force-pushed
the
2273_support
branch
from
6648f38 to
b246ada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue https://github.com/CartoDB/support/issues/2273
I made a quick test in one of the affected users database and the fix seems to work