Skip to content

grant usage on cartodb_id sequence when sharing read write #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2018
Merged

grant usage on cartodb_id sequence when sharing read write #323

merged 1 commit into from
Feb 15, 2018

Conversation

@alrocar
Copy link
Contributor

@alrocar alrocar commented Feb 15, 2018 •
edited
Loading

Closes #321

jgoizueta
jgoizueta approved these changes Feb 15, 2018
View reviewed changes
Copy link
Contributor

@jgoizueta jgoizueta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgaubert
Copy link
Contributor

Please, add someone of @CartoDB/engine as a reviewer.

@alrocar alrocar requested a review from dgaubert February 15, 2018 10:13
@alrocar
Copy link
Contributor Author

alrocar commented Feb 15, 2018

@dgaubert I added you :P let me know if you are available for CR or reassign to someone else, please

Thanks :)

@jgoizueta jgoizueta merged commit 0a58c05 into master Feb 15, 2018
@jgoizueta jgoizueta deleted the 321-grant-sequence branch February 15, 2018 15:29
@javitonino javitonino mentioned this pull request May 28, 2018
Merged
@dgaubert
Copy link
Contributor

Hey, I'm late to the party. Sorry about that. LGTM.

simon-contreras-deel
simon-contreras-deel reviewed May 29, 2018
View reviewed changes
Copy link

@simon-contreras-deel simon-contreras-deel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alrocar
Copy link
Contributor Author

alrocar commented May 29, 2018

Hey @dgaubert @oleurud , this was merged 3 months ago xDD, maybe you are looking for this PR -> #330

@simon-contreras-deel
Copy link

Thanks xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgaubert dgaubert Awaiting requested review from dgaubert

2 more reviewers

@simon-contreras-deel simon-contreras-deel simon-contreras-deel left review comments

@jgoizueta jgoizueta jgoizueta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alrocar @dgaubert @simon-contreras-deel @jgoizueta