Skip to content

create pkg-config file #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2020
Merged

create pkg-config file #523

merged 1 commit into from
Oct 28, 2020

Conversation

@djerius
Copy link
Contributor

@djerius djerius commented Oct 15, 2020

Create a pkg-config metadata file so that CLI11 can be found by pkg-config

@codecov
Copy link

codecov bot commented Oct 15, 2020 •
edited
Loading

Codecov Report

Merging #523 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #523   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines         3740      3740           
=========================================
  Hits          3740      3740

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89926dc...cf277a7. Read the comment docs.

henryiii
henryiii reviewed Oct 16, 2020
View reviewed changes
cmake/CLI11GeneratePkgConfig.cmake Outdated
set(DEST_DIR "${CMAKE_INSTALL_PREFIX}")
set(PACKAGE_VERSION "${VERSION_STRING}")

CONFIGURE_FILE("cmake/CLI11.pc.in" "CLI11.pc" @ONLY)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CONFIGURE_FILE("cmake/CLI11.pc.in" "CLI11.pc" @ONLY)
configure_file("cmake/CLI11.pc.in" "CLI11.pc" @ONLY)

henryiii
henryiii reviewed Oct 16, 2020
View reviewed changes
cmake/CLI11GeneratePkgConfig.cmake Outdated
@@ -0,0 +1,9 @@
set(DEST_DIR "${CMAKE_INSTALL_PREFIX}")
set(PACKAGE_VERSION "${VERSION_STRING}")
Copy link
Collaborator

@henryiii henryiii Oct 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use @PROJECT_VERSION@ (which is automatically set by CMake), and just use it inside the .pc.in file? And use @CMAKE_INSTALL_PREFIX@ too? If this is a convention, it could stay that way, but others, it seems to be simpler without adding new variables?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ignorance on my part of CMake. I've pushed a version with your suggestions.

@djerius djerius force-pushed the pkg-config branch 3 times, most recently from 7731a73 to 724f6ad Compare October 20, 2020 14:25
@henryiii henryiii merged commit e50a75f into CLIUtils:master Oct 28, 2020
@henryiii
Copy link
Collaborator

Thanks!

@github-actions github-actions bot added needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Oct 28, 2020
@henryiii henryiii removed the needs README Needs to be mentioned in the README label Oct 28, 2020
@djerius djerius deleted the pkg-config branch October 28, 2020 17:02
@henryiii henryiii added this to the v2.0 milestone Jun 24, 2021
@henryiii henryiii removed the needs changelog Hasn't been added to the changelog yet label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henryiii henryiii henryiii left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@djerius @henryiii