Skip to content

Conversation

@cbachhuber
Copy link
Collaborator

  • Added backticks around e.g. optional, such that the angle brackets are rendered in markdown
  • Changed link for further info to the suitable chapter, as I did not find info on optional or templates in the internals chapter
  • std::optional could be used as well, correct? Added to this paragraph

@codecov
Copy link

codecov bot commented Nov 30, 2019

Codecov Report

Merging #357 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #357   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        3352   3352           
=====================================
  Hits         3352   3352

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67dc672...9bb0b00. Read the comment docs.

@henryiii henryiii merged commit 7a4d376 into CLIUtils:master Nov 30, 2019
@henryiii
Copy link
Collaborator

Thanks!

@henryiii henryiii added this to the v1.9 milestone Dec 31, 2019
@cbachhuber cbachhuber deleted the fix-optionals-in-readme branch January 25, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants