Required flags not being informed as such by the help message

[vhborges]

This can be seen on the subcom_partitioned example in this repo: when run with --help, the --count flag will not be informed as required, despite it being so (not using it produces an error).

Is this an expected behaviour?

Edit: changed "--help-all" to "--help"

[phlptp]

if --help is used with this example

This is a timer: 4.1 us
K3Pi goofit fitter
Usage: C:\Users\phlpt\Documents\CLI11\build\examples\Debug\subcom_partitioned.exe [OPTIONS]

Options:
  -h,--help                   Print this help message and exit
[Option Group: Subcommands]
  Important
  Positionals:
    file TEXT REQUIRED          File name
  Options:
    -f,--file TEXT REQUIRED     File name
    -c,--count REQUIRED         Counter
[Option Group: Subcommands]
  Other
  Options:
    -d,--double FLOAT           Some Value

So the REQUIRED shows up

[phlptp]

The --help-all option is not enabled for this example
so running with a --help-all option will just show a warning message since the flag is unrecognized

This is a timer: 3.9 us
--file is required
Run with --help for more information.

if an actual help-all flag is added then

This is a timer: 9.3 us
K3Pi goofit fitter
Usage: C:\Users\phlpt\Documents\CLI11\build\examples\Debug\subcom_partitioned.exe [OPTIONS]

Options:
  -h,--help                   Print this help message and exit
  --help-all
[Option Group: Subcommands]
  Important
  Positionals:
    file TEXT REQUIRED          File name
  Options:
    -f,--file TEXT REQUIRED     File name
    -c,--count REQUIRED         Counter
[Option Group: Subcommands]
  Other
  Options:
    -d,--double FLOAT           Some Value

so it shows up correctly.

[phlptp]

What seems to be clear though is that more indication of an ERROR is needed so it wouldn't be mistaken for a help, and perhaps enabling help-all by default.
Also would probably benefit from #173

[vhborges]

Sorry, I actually meant --help instead of --help-all.

On my computer the REQUIRED is not shown with --help (using gcc/g++ version 9.2.0 and CLI11 version 1.8), look:

[phlptp]

OK, That is interesting. Can you check with the latest master just to make sure it wasn't updated recently?

[vhborges]

Indeed it appears to be fixed on master. Sorry for not checking it before.

[phlptp]

Great! That certainly wasn't an issue we knowingly fixed but I remember some updates around the code that generates the output recently so thought there was a chance it was resolved in master.

Thanks!

[henryiii]

Going to close since this seems to be resolved in the next release without any work, the best kind of issue. ;)