Skip to content

refactor(s3stream/wal): use an enum class to identify the WAL state #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024
Merged

refactor(s3stream/wal): use an enum class to identify the WAL state #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions s3stream/src/main/java/com/automq/stream/s3/wal/impl/block/BlockWALService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@
import java.util.concurrent.ExecutorService;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.atomic.AtomicLong;
import java.util.concurrent.atomic.AtomicReference;
import java.util.concurrent.locks.Lock;
import java.util.function.Function;
import org.apache.commons.lang3.StringUtils;
Expand Down Expand Up @@ -118,7 +118,7 @@ public class BlockWALService implements WriteAheadLog {
public static final int WAL_HEADER_TOTAL_CAPACITY = WAL_HEADER_CAPACITY * WAL_HEADER_COUNT;
private static final Logger LOGGER = LoggerFactory.getLogger(BlockWALService.class);
@SuppressWarnings("checkstyle:MemberName")
private final AtomicInteger WAL_STATE = new AtomicInteger(WalState.INIT);
private final AtomicReference<WalState> state = new AtomicReference<>(WalState.INIT);
private final AtomicBoolean resetFinished = new AtomicBoolean(false);
private final AtomicLong writeHeaderRoundTimes = new AtomicLong(0);
private final ExecutorService walHeaderFlusher = Threads.newFixedThreadPool(1, ThreadUtils.createThreadFactory("flush-wal-header-thread-%d", true), LOGGER);
Expand Down Expand Up @@ -278,28 +278,28 @@ private void parseRecordBody(long recoverStartOffset, RecordHeader readRecordHea

@Override
public WriteAheadLog start() throws IOException {
switch (WAL_STATE.get()) {
case WalState.INIT:
if (WAL_STATE.compareAndSet(WalState.INIT, WalState.STARTING)) {
switch (state.get()) {
case INIT:
if (state.compareAndSet(WalState.INIT, WalState.STARTING)) {
try {
doStart();
WAL_STATE.set(WalState.STARTED);
state.set(WalState.STARTED);
} finally {
if (WAL_STATE.get() != WalState.STARTED) {
WAL_STATE.compareAndSet(WalState.STARTING, WalState.INIT);
if (state.get() != WalState.STARTED) {
state.compareAndSet(WalState.STARTING, WalState.INIT);
LOGGER.warn("block WAL service started fail");
}
}
}
break;
case WalState.STARTING:
case STARTING:
LOGGER.warn("block WAL service is starting");
break;
case WalState.STARTED:
case STARTED:
LOGGER.warn("block WAL service already started");
break;
case WalState.SHUTTING_DOWN:
case WalState.SHUTDOWN:
case SHUTTING_DOWN:
case SHUTDOWN:
throw new IllegalStateException("block WAL service already shutdown");
default:
throw new IllegalStateException("invalid WAL state");
Expand Down Expand Up @@ -399,8 +399,8 @@ private void walHeaderReady(BlockWALHeader header) {
@Override
public void shutdownGracefully() {
for (; ; ) {
int state = WAL_STATE.get();
if (state == WalState.SHUTDOWN || WAL_STATE.compareAndSet(WalState.INIT, WalState.SHUTDOWN)) {
WalState state = this.state.get();
if (state == WalState.SHUTDOWN || this.state.compareAndSet(WalState.INIT, WalState.SHUTDOWN)) {
LOGGER.warn("block WAL service already shutdown or not started yet");
return;
}
Expand All @@ -409,20 +409,20 @@ public void shutdownGracefully() {
continue;
}
if (state == WalState.SHUTTING_DOWN
|| WAL_STATE.compareAndSet(state, WalState.SHUTTING_DOWN)) {
|| this.state.compareAndSet(state, WalState.SHUTTING_DOWN)) {
break;
}
}

if (WAL_STATE.compareAndSet(WalState.SHUTTING_DOWN, WalState.SHUTDOWN)) {
if (state.compareAndSet(WalState.SHUTTING_DOWN, WalState.SHUTDOWN)) {
boolean success = false;
try {
doShutdown();
success = true;
} finally {
if (!success) {
LOGGER.warn("block WAL service shutdown fail");
WAL_STATE.compareAndSet(WalState.SHUTDOWN, WalState.SHUTTING_DOWN);
state.compareAndSet(WalState.SHUTDOWN, WalState.SHUTTING_DOWN);
}
}
}
Expand Down Expand Up @@ -560,7 +560,7 @@ private CompletableFuture<Void> trim(long offset, boolean internal) {
}

private void checkStarted() {
if (WAL_STATE.get() != WalState.STARTED) {
if (state.get() != WalState.STARTED) {
throw new IllegalStateException("WriteAheadLog has not been started yet");
}
}
Expand All @@ -581,12 +581,12 @@ private SlidingWindowService.WALHeaderFlusher flusher() {
return () -> flushWALHeader(ShutdownType.UNGRACEFULLY);
}

private static class WalState {
public static final int INIT = 1;
public static final int STARTING = 2;
public static final int STARTED = 3;
public static final int SHUTTING_DOWN = 4;
public static final int SHUTDOWN = 5;
private enum WalState {
INIT,
STARTING,
STARTED,
SHUTTING_DOWN,
SHUTDOWN,
}

public static class BlockWALServiceBuilder {
Expand Down