Skip to content

support opn's options for loading a browser with arguments #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2016
Merged

support opn's options for loading a browser with arguments #1179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,13 +165,23 @@ var utils = {
}
}
},

// https://browsersync.io/docs/options
//https://www.npmjs.com/package/opn
//
/**
* Wrapper for open module - for easier stubbin'
* @param url
* @param name
* @param browser
*/
open: function (url, name) {
require("opn")(url, {app: name || null});
open: function (url, browser) {
var options = null;
if(_.isString(browser)) {
options = {app: browser};
} else if(Immutable.Map.isMap(browser)) {
options = {app: browser.toJS().app};
}
require("opn")(url, options);
},
/**
* @param {Boolean} kill
Expand Down