Changes to restore compatibility with Cleverbot's current interface #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/cleverbot/session.ex
Outdated
| `session_id` and `history`. | ||
| """ | ||
| defstruct session_id: nil, history: [] | ||
| defstruct session_id: "", history: ["", "", "", "", "", "", ""] |
There was a problem hiding this comment.
Is this now required? Does it not work with an empty list anymore?
|
One question, but otherwise this looks great. Thanks for taking the time to fix it! |
|
You're right, it is not necessary, just residues from early experiments I forgot to remove! Empty list works just fine. |
…()[]\/+=? caused Cleverbot to respond with DENIED.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleverbot now requires a cookie, and the url for the POST request is different. I copied most changes from a respective Python API (https://github.com/folz/cleverbot.py). Seems to work like this for now.