Skip to content

Conversation

@dragid10
Copy link
Member

@dragid10 dragid10 commented Oct 15, 2025

Issue Link 🔗: #774

Issue: #744

Type of Change

  • Bug fix 🐞
  • New feature/page
  • Documentation update
  • Other

Description 📋

What:

The about.html page was unable to load the actual member details because we stopped loading the yaml. To fix this, we converted the leadership.yaml file to leadership.json instead (to match the other data files) and load the json file in

Changes:

  • Transform leadership.yaml to leadership.json: Fixes about.html page
  • Remove Yaml-frontmatter pre-commit hook: It doesn't seem that we're actually loading any yaml data anymore, so there doesn't really seem to be a need to check for the frontmatter

Checklist ✅

  • Followed the Code of Conduct and Contribution Guide
  • Ran pre-commit run --all
  • All tests pass locally
  • Added tests (if applicable)
  • Documentation updated (if applicable)

Additional Notes & Screenshots

Add any additional notes or comments that might be helpful for the reviewers.

The `about.html` page was unable to load the actual member details because we stopped loading the yaml. To fix this, we converted the `leadership.yaml` file to `leadership.json` instead (to match the other data files) and load that in
@dragid10 dragid10 linked an issue Oct 15, 2025 that may be closed by this pull request
@dragid10 dragid10 self-assigned this Oct 15, 2025
@dragid10 dragid10 requested review from a team and kjaymiller October 15, 2025 20:55
@dragid10
Copy link
Member Author

dragid10 commented Oct 15, 2025

Weirdly enough, I'm not allowed to add the @BlackPythonDevs/devteam as reviewers 🤔
It doesn't come up as an option for me
image

Copy link
Contributor

@kjaymiller kjaymiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this fixed.

I'm going to push onto that we can have the information returned.

@kjaymiller kjaymiller merged commit 6841c66 into gh-pages Oct 16, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Leaders and advisors are missing on website

3 participants