-
Notifications
You must be signed in to change notification settings - Fork 66
Add leadership model page #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
03dbb7c
09cf99d
f4129a9
d15b1c3
dfa54eb
0db655a
4f46398
b84abf1
da98d7c
d39afd5
667bfe1
5c741b5
9ff600e
3bffa90
35976fd
300797f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -30,6 +30,9 @@ navigation: | |||
| - text: Community | ||||
| url: /community/ | ||||
| fa: fa fa-users fa-fw | ||||
| - text: Meet our leaders | ||||
| url: /meet-our-leaders/ | ||||
|
||||
| url: /meet-our-leaders/ |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| fa: fa fa-user-tie fa-fw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please confirm the changes you want me to make in the _config.yml file. Do you want the /meet-our-leaders/ completely removed or you want the name changed to leadership ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
completely removed from the _config.yml as it's used for navigation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. I'm curious as to how we plan to navigate to the leadership page if it isn't included in the navigation links.
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,172 @@ | ||||||||||||
| --- | ||||||||||||
| layout: default | ||||||||||||
| lang: en | ||||||||||||
| title: Meet our leaders | ||||||||||||
|
||||||||||||
| title: Meet our leaders | |
| title: Leadership |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <article class="leadership-photo-container"> | |
| <img class="leadership-photo" alt="photo of Oleksis" src="https://github.com/oleksis.png"> | |
| <p><strong>Oleksis Fraga</strong><br/> | |
| Technical Manager</p> | |
| </article> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is removed as per #463
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a simplified list like our leadership council.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplify to a Markdown List
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -8,9 +8,11 @@ | |||||
| live_server_url = "http://127.0.0.1:4000" | ||||||
|
|
||||||
| routes = [ | ||||||
| ("blog"), | ||||||
| ("about"), | ||||||
| ("community"), | ||||||
| ("events"), | ||||||
| ("community"), | ||||||
| ("meet-our-leaders"), | ||||||
|
||||||
| ("meet-our-leaders"), | |
| ("leadership"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I make this change, I encounter a failing test as we don't have a leadership route. Should I update the naming convention from meet-our-leaders.md to leadership.md instead? A 👍 for approval and I'll proceed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.