Add supported text field to anthropic citation response #14026
Merged
+24
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@krrishdholakia Can you take a look? |
|
Lint failure is unrelated |
|
@ishaan-jaff Can you help take a look? |
| @@ -797,7 +797,15 @@ def extract_response_content(self, completion_response: dict) -> Tuple[ | |||
| if content.get("citations") is not None: | |||
| if citations is None: | |||
| citations = [] | |||
| citations.append(content["citations"]) | |||
| citations.append( | |||
There was a problem hiding this comment.
add a unit test for this behaviour inside test_litellm/
|
@TomeHirata heads up this needed to be reverted - it looks like this change broke this test. I want to help get this merged in again - could you help take a 2nd look why this led to test_completion_claude_3_function_call_with_streaming failing ? Specific test that broke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Add supported text field to anthropic citation response
Relevant issues
#7970
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🆕 New Feature
Changes
Add supported text field to anthropic citation response to tell which sentence is supported by each citation.