Skip to content

add enginefactory option type #17074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 27, 2025
Merged

add enginefactory option type #17074

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f8cda2
add enginefactory option type
ThalerMatthias Aug 27, 2025
dc7bf70
prettier formatting
ThalerMatthias Aug 27, 2025
5f81e76
only import type
ThalerMatthias Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/dev/core/src/Engines/engineFactory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import type { AbstractEngine } from "./abstractEngine";
import { Engine } from "./engine";
import { NullEngine } from "./nullEngine";
import { WebGPUEngine } from "./webgpuEngine";
import { NullEngine, type NullEngineOptions } from "./nullEngine";
import { WebGPUEngine, type WebGPUEngineOptions } from "./webgpuEngine";
import type { EngineOptions } from "./thinEngine";

/**
* Helper class to create the best engine depending on the current hardware
Expand All @@ -13,14 +14,14 @@ export class EngineFactory {
* @param options Defines the options passed to the engine to create the context dependencies
* @returns a promise that resolves with the created engine
*/
public static async CreateAsync(canvas: HTMLCanvasElement, options: any): Promise<AbstractEngine> {
public static async CreateAsync(canvas: HTMLCanvasElement, options?: WebGPUEngineOptions | EngineOptions | NullEngineOptions): Promise<AbstractEngine> {
const supported = await WebGPUEngine.IsSupportedAsync;
if (supported) {
return await WebGPUEngine.CreateAsync(canvas, options);
return await WebGPUEngine.CreateAsync(canvas, options as WebGPUEngineOptions);
}
if (Engine.IsSupported) {
return new Engine(canvas, undefined, options);
return new Engine(canvas, undefined, options as EngineOptions);
}
return new NullEngine(options);
return new NullEngine(options as NullEngineOptions);
}
}
Loading