Pass through gizmo drag observer messages #17055
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
I use unkown here but can use any aswell.
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
This reverts commit 3fce1bb.
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17055/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17055/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17055/merge#BCU1XR#0 |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
packages/dev/inspector/src/components/sceneExplorer/entities/sceneTreeItemComponent.tsx
Outdated
Show resolved
Hide resolved
Head branch was pushed to by a user without write access
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17055/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17055/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17055/merge#BCU1XR#0 |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
My last PR (#17055) passed through the `eventData`, but I forgot about the `eventState`. This PR unpacks the `eventState` when notifying gizmo drag observers, along with the `eventData`.
I was recently working on a feature that utilized the PositionGizmo, adjusting its behavior based on whether the shift key was pressed. I was surprised to find that the pointer info wasn't available at the PositionGizmo level because the notification packet from the PointerDragBehavior isn't being passed through. This seems to have been done intentionally, though I'm not sure why.
This PR proposes that the notification packets for the specialized gizmo PointerDragBehavior be passed through their onDragObservables. This implementation keeps the Observer type dynamic to ease future development.
If the current behavior was intentional, I'm curious to know why.