Skip to content

NRGE: Fix error in console at load time (WebGPU) #17054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2025
Merged

NRGE: Fix error in console at load time (WebGPU) #17054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/tools/nodeRenderGraphEditor/src/components/preview/previewManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,16 @@ export class PreviewManager {

this._scene = scene;

this._dummyExternalTexture?.dispose();
const dummyTexture = this._dummyExternalTexture;

// The texture could be used by the command buffer that will be processed at the end of the frame, so we can't dispose it immediately
// We must call setTimeout(0) two times to make sure we dispose the texture at the right time (the first setTimeout(0) executes just after _initSceneAsync has been processed because it is async, which is too soon)
setTimeout(() => {
setTimeout(() => {
dummyTexture?.dispose();
}, 0);
}, 0);

this._dummyExternalTexture = new Texture("https://assets.babylonjs.com/textures/Checker_albedo.png", this._scene, true);
this._dummyExternalTexture.name = "Dummy external texture for preview NRGE";

Expand Down
Loading