Skip to content

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Aug 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 22, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 22, 2025

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to prevent adding more conditions in alphaState ? it sounds like separate blending is adding cost to the simple blend which is used 99.9% of the time. I wonder how we could support both without extra perf impact

@Popov72
Copy link
Contributor Author

Popov72 commented Aug 22, 2025

Is there a way to prevent adding more conditions in alphaState ? it sounds like separate blending is adding cost to the simple blend which is used 99.9% of the time. I wonder how we could support both without extra perf impact

I refactored the code to have a single additional check.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 22, 2025

@deltakosh deltakosh enabled auto-merge (squash) August 22, 2025 15:51
@deltakosh deltakosh merged commit eaa3423 into BabylonJS:master Aug 22, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants