Skip to content

Conversation

deltakosh
Copy link
Contributor

@deltakosh deltakosh commented Aug 21, 2025

Also allows NPE to resync existing particles systems

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 21, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 21, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 21, 2025

@deltakosh deltakosh merged commit 5efd7c7 into master Aug 21, 2025
18 checks passed
@deltakosh deltakosh deleted the npe-helper-2 branch August 21, 2025 22:05
import { SceneInstrumentation } from "core/Instrumentation/sceneInstrumentation";
import type { ThinParticleSystem } from "core/Particles/thinParticleSystem";
import type { ParticleSystemSet } from "core/Particles/particleSystemSet";
import { EngineStore } from "core/Engines";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { EngineStore } from "core/Engines";
import { EngineStore } from "core/Engines/engineStore";

import { SceneInstrumentation } from "core/Instrumentation/sceneInstrumentation";
import type { ThinParticleSystem } from "core/Particles/thinParticleSystem";
import type { ParticleSystemSet } from "core/Particles/particleSystemSet";
import { EngineStore } from "core/Engines";
import type { ParticleSystem } from "core/Particles";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import type { ParticleSystem } from "core/Particles";
import type { ParticleSystem } from "core/Particles/particleSystem";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants