-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add support for more features in the particules to NPE converter #17050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17050/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17050/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17050/merge#BCU1XR#0 |
Visualization tests for WebGPU |
WebGL2 visualization test reporter: |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17050/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17050/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17050/merge#BCU1XR#0 |
Visualization tests for WebGPU |
WebGL2 visualization test reporter: |
import { SceneInstrumentation } from "core/Instrumentation/sceneInstrumentation"; | ||
import type { ThinParticleSystem } from "core/Particles/thinParticleSystem"; | ||
import type { ParticleSystemSet } from "core/Particles/particleSystemSet"; | ||
import { EngineStore } from "core/Engines"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { EngineStore } from "core/Engines"; | |
import { EngineStore } from "core/Engines/engineStore"; |
import { SceneInstrumentation } from "core/Instrumentation/sceneInstrumentation"; | ||
import type { ThinParticleSystem } from "core/Particles/thinParticleSystem"; | ||
import type { ParticleSystemSet } from "core/Particles/particleSystemSet"; | ||
import { EngineStore } from "core/Engines"; | ||
import type { ParticleSystem } from "core/Particles"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import type { ParticleSystem } from "core/Particles"; | |
import type { ParticleSystem } from "core/Particles/particleSystem"; |
Also allows NPE to resync existing particles systems