NavigationPluginV2 addon #17035

RolandCsibrei · 2025-08-16T22:02:34Z

Already working examples (I need to tide up the code a bit):
http://localhost:1338/#KVQP83#203 = navmesh generation stuff
http://localhost:1338/#KVQP83#209 = obstacles
http://localhost:1338/#KVQP83#213 = offmesh
http://localhost:1338/#KVQP83#245 = move along navmesh with WASD
http://localhost:1338/#KVQP83#244 = raycast

bjsplat · 2025-08-16T22:03:57Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-16T22:03:58Z

Reviewer - this PR has made changes to one or more package.json files.

RolandCsibrei · 2025-08-16T22:07:05Z

bjsplat · 2025-08-16T23:10:07Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-16T23:10:07Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-17T04:44:32Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-17T04:44:32Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-17T08:02:28Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-17T08:02:29Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-17T09:30:15Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-17T09:30:16Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-17T10:06:32Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-17T10:06:33Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-17T11:43:46Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-17T11:43:46Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-17T12:15:11Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-17T12:15:12Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-20T07:05:53Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-20T07:05:54Z

Reviewer - this PR has made changes to one or more package.json files.

added TODO

bjsplat · 2025-08-20T13:46:43Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-20T13:46:44Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-20T16:59:06Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-20T16:59:07Z

Reviewer - this PR has made changes to one or more package.json files.

…addon

bjsplat · 2025-08-22T19:26:17Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-22T19:26:17Z

Reviewer - this PR has made changes to one or more package.json files.

ryantrem · 2025-08-22T21:51:30Z

packages/dev/addons/src/navigation/types.ts

+/**
+ *
+ */
+export interface INavigationEnginePluginV2 extends INavigationEnginePlugin {


I would say lets just remove the v2 interface, and just have the new concrete class that also implements the v1 interface (as it already does).

ryantrem · 2025-08-22T22:01:00Z

packages/dev/core/src/Misc/index.ts

@@ -89,3 +89,5 @@ export * from "../ShadersWGSL/rgbdEncode.fragment";
 // CopyTextureToTexture
 export * from "../Shaders/copyTextureToTexture.fragment";
 export * from "../ShadersWGSL/copyTextureToTexture.fragment";
+
+export * from "./tools.internals";


Revert? Doesn't seem necessary, especially since you are importing directly from the path anyway.

If it's not exported it's not visible in the ADDONS package.

Because of UMD? @deltakosh, @sebavan - it seems like we shouldn't export internal tools from the core package, any thoughts?

packages/dev/addons/src/navigation/index.ts

packages/dev/addons/src/navigation/worker/navmesh-worker.ts

ryantrem · 2025-08-22T22:38:20Z

packages/dev/addons/src/navigation/plugin/RecastNavigationJSPlugin.ts

+     * The navmesh query created from the navmesh
+     * @remarks This is used to query the navmesh for pathfinding and other navigation tasks
+     */
+    public navMeshQuery!: NavMeshQuery;


Why isn't this nullable? It's not assigned until some functions get called, right?

The navMeshQuery gets created automatically when the navMesh is generated. If navMesh generation fails an error is thrown so basically you can't do anything with the plugin. navMeshQuery is used in a lot of functions (called in the render-loop) and checking for non-null value would be a performance bottleneck.

So is the idea that you construct the object and then you must call either buildFromNavmeshData or createNavMesh? If so, is the object in an invalid state after construction but before one of these functions are called? Once you call one of these functions, can you call either one of them subsequently on the same instance?

packages/dev/addons/src/navigation/common/convert.ts

packages/dev/addons/src/navigation/types.ts

packages/dev/addons/src/navigation/common/smooth-path.ts

ryantrem · 2025-08-22T22:48:44Z

packages/dev/addons/src/navigation/factory/common.ts

+import { GenerateNavMesh } from "../generator";
+import type { RecastNavigationJSPluginV2 } from "../plugin/RecastNavigationJSPlugin";
+
+export let BjsRecast: RecastInjection;


Seems like this should be nullable.

I'm thinking about this one. I agree that it's not the best practice to leave variables unitialized but this one is maybe an exception. It must be initialized during the init process otherwise the nav engine will not be operational. If I make it nullable, there must be checks for non-null value before using the variable howvever if something fails upon init it makes no sense to access it. I'm not arguing here just loudly thinking. If you still want me to make it nullable, no problem.

What about exporting an accessor function instead (like GetBjsRecast or something) that is synchronous but throws if the value is not set. Then you'd just have a nullable local module scoped variable (which is correctly typed), and usages of it don't need to do any checks or asynchrony, it will just throw if it is null. It's effectively a runtime assertion to protect against programming errors.

bjsplat · 2025-08-23T23:47:39Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-23T23:47:39Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-24T14:20:55Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-24T14:20:55Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-25T05:37:26Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-25T05:37:26Z

Reviewer - this PR has made changes to one or more package.json files.

RolandCsibrei · 2025-08-25T07:46:39Z

@ryantrem since the options parameter is for several functions the same I'll introduce a type for it

ryantrem · 2025-08-25T18:33:28Z

packages/dev/addons/src/navigation/factory/factory.worker.ts

+            navMeshQuery: NavMeshQuery;
+            tileCache?: TileCache;
+        }>((resolve, _reject) => {
+            GenerateNavMeshWithWorker(meshes, parameters, {


Seems like GenerateNavMeshWithWorker can synchronously throw, but there is no try/catch with a call to _reject. I think that should be added if I'm reading the code correctly.

ryantrem · 2025-08-25T18:36:24Z

packages/dev/addons/src/navigation/generator/generator.worker.ts

+    // callback function to process the message from the worker
+    workerOptions.worker.onmessage = (e) => {
+        if ((e as any).data?.success === false) {
+            throw new Error(`Unable to generate navMesh: ${e}`);


Where do these errors go? I assume they just show up as console errors, and the promise on the other side of this never resolves or rejects?

ryantrem · 2025-08-25T18:40:37Z

packages/dev/addons/src/navigation/common/getters.ts

+    const positions = [];
+    const indices = [];


These are untyped.

Suggested change

const positions = [];

const indices = [];

const positions: number[] = [];

const indices: number[] = [];

ryantrem · 2025-08-25T18:41:19Z

packages/dev/addons/src/navigation/common/getters.ts

+                continue;
+            }
+
+            const worldMatrices = [];


Suggested change

const worldMatrices = [];

const worldMatrices: Matrix[] = [];

ryantrem · 2025-08-25T19:01:11Z

packages/dev/addons/src/navigation/types.ts

+    /**
+     * The error message if the path computation failed.
+     */
+    error?: {


Isn't error still only valid/present when sucess is false? Still seems like this could be a discriminated union to be more clear, unless it causes some problem.

RolandCsibrei added 5 commits August 6, 2025 19:16

greasedline far positions precision loss fix

1fa1e80

Merge branch 'master' of github.com:BabylonJS/Babylon.js

f5d2ec1

First commit

ea9fa49

Correct handling of Intermediates

1e1e9f6

Added docs, tileCache support, etc.

70252be

RolandCsibrei marked this pull request as draft August 16, 2025 22:03

Removed unused class properties

7fd0f03

Formatting, refactor

e144dd1

fixed export paths

89f9a5d

fixing imports

cc76916

Backwards compatible Uint32Array handling

63a6793

updated imports

c2c2be9

updating imports

b982f14

recast lib injection

8cafd03

renaming

b2c5447

added TODO

optioinal recastInjection parameter

dea66a4

Merge branch 'master' of github.com:BabylonJS/Babylon.js into recast-…

395b738

…addon

ryantrem reviewed Aug 22, 2025

View reviewed changes

ryantrem's reviews

3fc0ed0

RolandCsibrei requested review from ryantrem and deltakosh August 24, 2025 04:39

some small fixes

67db348

moveAlongWithVelocity and raycast added

bd6f3df

ryantrem reviewed Aug 25, 2025

View reviewed changes

	const worldMatrices = [];
	const worldMatrices: Matrix[] = [];

NavigationPluginV2 addon #17035

Are you sure you want to change the base?

NavigationPluginV2 addon #17035

Conversation

RolandCsibrei commented Aug 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bjsplat commented Aug 16, 2025

Uh oh!

bjsplat commented Aug 16, 2025

Uh oh!

RolandCsibrei commented Aug 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bjsplat commented Aug 16, 2025

Uh oh!

bjsplat commented Aug 16, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 20, 2025

Uh oh!

bjsplat commented Aug 20, 2025

Uh oh!

bjsplat commented Aug 20, 2025

Uh oh!

bjsplat commented Aug 20, 2025

Uh oh!

bjsplat commented Aug 20, 2025

Uh oh!

bjsplat commented Aug 20, 2025

Uh oh!

bjsplat commented Aug 22, 2025

Uh oh!

bjsplat commented Aug 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RolandCsibrei commented Aug 16, 2025 •

edited

Loading

RolandCsibrei commented Aug 16, 2025 •

edited

Loading