- 
                Notifications
    
You must be signed in to change notification settings  - Fork 241
 
Reload certificates for all client credential based issues #3430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
           I am not sure how I can run the extended tests locally (I get credential missing issues even without this change). If they aren't run during merge, let me know how I can run them locally :)  | 
    
| 
           Integration tests all happy locally!  | 
    
              
                    keegan-caruso
  
              
              approved these changes
              
                  
                    Jul 23, 2025 
                  
              
              
            
            
              
                    bgavrilMS
  
              
              approved these changes
              
                  
                    Jul 30, 2025 
                  
              
              
            
            
              
                    jmprieur
  
              
              approved these changes
              
                  
                    Jul 30, 2025 
                  
              
              
            
            
| 
           discussed risks with Bogdan for other invalid_client (bad GUID). This is only one retry so taking it  | 
    
  This was referenced Aug 15, 2025 
      
     Merged
  
      
     Closed
  
      
     Closed
  
  This was referenced Oct 28, 2025 
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Reload certificates for all client credential based issues
Change retry logic to reload certificates on all credential issues, not just revocation/expiration.
Description
The current behavior of the library is to reload and retry certificates in the event that the certificate fails for one of the following two issues:
There is a great many other reasons that authentication can fail that fall outside of these two scenarios. If any of those additional scenarios occur the certificate will never be reloaded.
As a result, if a bad certificate is installed on the machine and picked up, and subsequently rotated, a service restart is needed for the new certificate to be used.
Fixes #3429