Skip to content

fix: use TemporaryDirectory instead of NamedTemporaryFile for MLTable… #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: use TemporaryDirectory instead of NamedTemporaryFile for MLTable… #3618

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e8c87c8
fix: use TemporaryDirectory instead of NamedTemporaryFile for MLTable…
CynicDog Jun 13, 2025
ae82531
Merge branch 'main' into cynicdog/model-monitoring-uri_folder-to-mltable
CynicDog Jun 21, 2025
3daaca3
Merge branch 'main' into cynicdog/model-monitoring-uri_folder-to-mltable
CynicDog Jul 7, 2025
aa4889e
Merge branch 'main' into cynicdog/model-monitoring-uri_folder-to-mltable
CynicDog Jul 26, 2025
5edf3e1
Merge branch 'main' into cynicdog/model-monitoring-uri_folder-to-mltable
CynicDog Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions cli/monitoring/components/custom_preprocessing/src/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,22 +75,22 @@ def preprocess(
# Data column is a list of objects, convert it into string because spark.read_json cannot read object
table = table.convert_column_types({"data": mltable.DataType.to_string()})

# Use NamedTemporaryFile to create a secure temp file
with tempfile.NamedTemporaryFile(delete=False) as temp_file:
save_path = temp_file.name
table.save(save_path)

# Save preprocessed_data MLTable to temp location
des_path = preprocessed_input_data + "temp"
fs = AzureMachineLearningFileSystem(des_path)
print("MLTable path:", des_path)
# TODO: Evaluate if we need to overwrite
fs.upload(
lpath=save_path,
rpath="",
**{"overwrite": "MERGE_WITH_OVERWRITE"},
recursive=True,
)
with tempfile.TemporaryDirectory() as temp_dir:
table.save(temp_dir)
print(f"Temporary MLTable saved at: {temp_dir}")

# Construct remote destination path
des_path = preprocessed_input_data + "temp"
fs = AzureMachineLearningFileSystem(des_path)

print(f"Uploading MLTable to: {des_path}")
fs.upload(
lpath=temp_dir, # this is the local directory with the MLTable metadata
rpath="",
**{"overwrite": "MERGE_WITH_OVERWRITE"},
recursive=True,
)
print("Upload complete.")

# Read mltable from preprocessed_data
df = read_mltable_in_spark(mltable_path=des_path)
Expand Down