Skip to content

Conversation

nick863
Copy link
Member

@nick863 nick863 commented Aug 28, 2025

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@nick863 nick863 changed the title Add test for DeepResearch Add test for DeepResearch and telemetry. Aug 28, 2025
@nick863 nick863 marked this pull request as ready for review August 28, 2025 16:07
@Copilot Copilot AI review requested due to automatic review settings August 28, 2025 16:07
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds telemetry test support for the DeepResearch tool functionality. The changes enable comprehensive testing of telemetry instrumentation when using DeepResearch capabilities within the Azure AI Agents SDK.

Key changes include:

  • Addition of DeepResearch tool test methods in both sync and async instrumentor test classes
  • Enhanced telemetry verification logic to handle DeepResearch-specific spans and annotations
  • Improved error messaging in the trace verifier for better debugging

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
test_ai_instrumentor_base.py Adds DeepResearch tool helper method and updates span checking logic for annotations and variable span counts
test_ai_agents_instrumentor_async.py Implements async test for DeepResearch tool telemetry with content recording
test_ai_agents_instrumentor.py Implements sync test for DeepResearch tool telemetry with content recording
gen_ai_trace_verifier.py Improves error message formatting for better debugging of key mismatches
_ai_agents_instrumentor.py Adds comment explaining DeepResearch tool handling
assets.json Updates asset tag for test recordings

@nick863 nick863 force-pushed the nirovins/add_deep_research_test branch from f25034d to 1d178e8 Compare August 28, 2025 16:26
@nick863 nick863 merged commit 6df5c84 into main Aug 28, 2025
19 checks passed
@nick863 nick863 deleted the nirovins/add_deep_research_test branch August 28, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants