[Bug Fix] Query Items with none partititon key #42747
Open
+37
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where calling query_items with partition_key=None would cause a duplicate argument error. The fix modifies the parameter handling logic to use pop() with a default value instead of checking for existence before popping, which eliminates the duplicate argument issue.
- Refactors partition key parameter handling in both sync and async container query methods
- Adds comprehensive test coverage for the None partition key scenario
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/cosmos/azure-cosmos/azure/cosmos/container.py | Updates sync container query_items method to handle None partition key properly |
| sdk/cosmos/azure-cosmos/azure/cosmos/aio/_container.py | Updates async container query_items method to handle None partition key properly |
| sdk/cosmos/azure-cosmos/tests/test_query.py | Adds test case for sync query with None partition key |
| sdk/cosmos/azure-cosmos/tests/test_query_async.py | Adds test case for async query with None partition key |
kushagraThapar
approved these changes
Aug 28, 2025
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug where partition key is none would break query items because of a duplicate argument error.