Simplify and enhance discover_targeted_packages
#42740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies and enhances the discover_targeted_packages function by improving glob pattern handling and adding better test package filtering. The changes make the package discovery more robust and comprehensive while ensuring test packages are properly excluded.
Key changes:
- Simplified glob operations by using recursive globbing instead of multiple explicit patterns
- Added filtering to exclude packages within test/tests directories
- Enhanced test coverage with a new comprehensive test against the entire SDK
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
eng/tools/azure-sdk-tools/ci_tools/functions.py |
Simplified glob operations using recursive patterns and added test directory filtering |
eng/tools/azure-sdk-tools/tests/integration/test_package_discovery.py |
Added comprehensive test for SDK-wide package discovery and refactored path variables |
…ing default of **
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively, the first glob match needs to be provided
**to act recursively. Thesdk/check explicitly will handle any*passed in. Maintaining that for backwards compatibility for now.