Support multiple open api def for toolset. #42728
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howieleung
requested review from
dargilco,
jhakulin,
trangevi,
glharper and
nick863
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the OpenApiTool functionality within the ToolSet to support multiple OpenAPI definitions. The main improvement allows adding multiple API definitions to a single OpenApiTool instance rather than requiring separate tools for each API specification.
Key Changes
- Modified the
add_definitionmethod to accept optional descriptions - Enhanced the
addmethod to merge new OpenApiTool definitions into existing OpenApiTool instances - Added overloaded
removemethods to support removing specific API definitions by name or entire OpenApiTool instances
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…-sdk-for-python into howie/multi-tool-def
nick863
approved these changes
Aug 28, 2025
jhakulin
reviewed
Aug 28, 2025
|
|
||
|
|
||
| # Special handling for OpenApiTool - add definitions to existing tool instead of raising error | ||
| if isinstance(tool, OpenApiTool): |
There was a problem hiding this comment.
Not sure we should do this. Having specific type checks for certain tools in ToolSet does not feel optimal
jhakulin
reviewed
Aug 28, 2025
| self._tools.append(tool) | ||
|
|
||
| def remove(self, tool_type: Type[Tool]) -> None: | ||
| @overload | ||
| def remove(self, tool_type: Type[OpenApiTool], *, name: str) -> None: |
There was a problem hiding this comment.
Similar comment, I would not add tool specific overloads in Toolset. If Tool abstraction would contain add and remove then we would not need this.
jhakulin
requested changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines