[OperationalInsights] onboarding autorest - Create hybrid repo #16903

dabenhamMic · 2022-01-24T11:53:15Z

Description

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate ChangeLog.md file(s) has been updated:
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  - {Please put the link here}
- the markdown help files have been regenerated using the commands listed here

…Workspaces and Tables

dabenhamMic · 2022-01-24T12:32:23Z

Hi @LucasYao93 , this PR is meant to replace #16826
what is still missing here?

… and remove workspace

src/OperationalInsights/OperationalInsights.Autorest/README.md

...lInsights/OperationalInsights.Autorest/examples/Get-AzOperationalInsightsDeletedWorkspace.md

...sights/OperationalInsights.Autorest/test/Get-AzOperationalInsightsDeletedWorkspace.Tests.ps1

LucasYao93 · 2022-01-25T05:38:21Z

Hi @LucasYao93 , this PR is meant to replace #16826 what is still missing here?

Please add examples and test cases for each cmdlet.

…zOperationalInsightsWorkspace, 'New-AzOperationalInsightsTable. Get-AzOperationalInsightsDeletedWorkspace added tests but kept skip flag as endoint is nt avialable

dabenhamMic · 2022-01-31T18:10:32Z

@LucasYao93 @wyunchi-ms tests, recordings, and examples were added.

… RestoredLogs in new and update "Table" resource re ran autorest - no additional files created

src/OperationalInsights/OperationalInsights.Autorest/README.md

LucasYao93 · 2022-02-10T01:50:26Z

Hi @dabenhamMic,

The examples of the cmdlet is incorrect. You can following the https://github.com/Azure/azure-powershell/blob/generation/src/Databricks/examples/Get-AzDatabricksWorkspace.md.

dabenhamMic · 2022-02-13T14:49:46Z

Hi @dabenhamMic,

The examples of the cmdlet is incorrect. You can following the https://github.com/Azure/azure-powershell/blob/generation/src/Databricks/examples/Get-AzDatabricksWorkspace.md.

@LucasYao93 it is unclear from your comment which cmdlet has the wrong example?

The file of examples should only include example of the cmdlet and must conform to a fixed format.Otherwise, it will cause an error https://dev.azure.com/azure-sdk/public/_build/results?buildId=1349007&view=logs&jobId=e1b7b984-9f58-529f-7c5a-f15f8e35cfa6&j=e1b7b984-9f58-529f-7c5a-f15f8e35cfa6&t=9a0cd9ed-0b8b-525f-138d-85a363b757e6

dabenhamMic · 2022-03-07T07:36:11Z

@LucasYao93 ,what is needed here in order to merge this pr?

BethanyZhou · 2022-03-07T08:50:27Z

/azp run

azure-pipelines · 2022-03-07T08:50:46Z

Azure Pipelines successfully started running 3 pipeline(s).

src/OperationalInsights/OperationalInsights.Autorest/README.md

BethanyZhou · 2022-03-07T09:10:55Z

As @isra-fel mentioned in office hour meeting, please correct example files.

…ontent

...lInsights/OperationalInsights.Autorest/examples/Get-AzOperationalInsightsDeletedWorkspace.md

…Get-AzOperationalInsightsDeletedWorkspace.md

src/OperationalInsights/OperationalInsights.Autorest/examples/Get-AzOperationalInsightsTable.md

...lInsights/OperationalInsights.Autorest/examples/Get-AzOperationalInsightsDeletedWorkspace.md

…Get-AzOperationalInsightsDeletedWorkspace.md

BethanyZhou · 2022-03-08T01:44:18Z

Hi @dabenhamMic , Our current example template format is as follow:
### {example title}
```powershell
{code}

{output}
```

{description}

Could you modify your example format? I think this is the root cause why there are some build errors.

src/OperationalInsights/OperationalInsights.Autorest/examples/Get-AzOperationalInsightsTable.md

...rationalInsights/OperationalInsights.Autorest/examples/New-AzOperationalInsightsWorkspace.md

...erationalInsights/OperationalInsights.Autorest/examples/Remove-AzOperationalInsightsTable.md

…OperationalInsightsTable cmdltes

BethanyZhou · 2022-03-14T03:36:31Z

/azp run

azure-pipelines · 2022-03-14T03:36:48Z

Azure Pipelines successfully started running 3 pipeline(s).

BethanyZhou

LGTM

LucasYao93 and others added 4 commits January 14, 2022 11:45

[OperationalInsights] init.

6485584

[OperationalInsights] rename parameter name.

a0863cb

update Readme.md with swagger files needed for autorest: Operations, …

81a9f35

…Workspaces and Tables

ran autorest, readme.md files updated

15c43db

update .md files for Get deleted workspaces, get table, get workspace…

fc8c7af

… and remove workspace

wyunchi-ms mentioned this pull request Jan 25, 2022

[OperationalInsights] Partial transition to auto code generation #16826

Closed

8 tasks

wyunchi-ms reviewed Jan 25, 2022

View reviewed changes

wyunchi-ms assigned LucasYao93, wyunchi-ms and dabenhamMic Jan 25, 2022

wyunchi-ms added the needs-revision label Jan 25, 2022

dabenhamMic added 6 commits January 26, 2022 13:13

added missing documentation for all new cmdlets

c9a986c

update examples folder with existing documentation under docs folder

e24506e

update main readme.md file with swagger specs

19f66c7

get workspaces tests

23b8c51

added tests and recordings for: Get-AzOperationalInsightsTable, Get-A…

d789f2f

…zOperationalInsightsWorkspace, 'New-AzOperationalInsightsTable. Get-AzOperationalInsightsDeletedWorkspace added tests but kept skip flag as endoint is nt avialable

added all missing tests and recordings

46542d2

dabenhamMic added this to the Backlog milestone Jan 31, 2022

add directive to readme.md to remove the option to set SearchLogs and…

e987cfb

… RestoredLogs in new and update "Table" resource re ran autorest - no additional files created

isra-fel reviewed Feb 4, 2022

View reviewed changes

src/OperationalInsights/OperationalInsights.Autorest/README.md Outdated Show resolved Hide resolved

IdactionAuto previously approved these changes Feb 4, 2022

View reviewed changes

dabenhamMic dismissed IdactionAuto’s stale review via aab6fd9 February 7, 2022 08:31

update directives for code gen

68b9d86

dabenhamMic force-pushed the feature/OperationalInsights branch from aab6fd9 to 68b9d86 Compare February 7, 2022 08:44

update .md files after package build

5656664

dabenhamMic removed the needs-revision label Mar 7, 2022

re ran all tests in record mode, added Move-AzOperationalInsightsTable

50bf4cf

BethanyZhou assigned BethanyZhou and unassigned LucasYao93, wyunchi-ms and dabenhamMic Mar 7, 2022

BethanyZhou reviewed Mar 7, 2022

View reviewed changes

src/OperationalInsights/OperationalInsights.Autorest/README.md Outdated Show resolved Hide resolved

dabenhamMic added 2 commits March 7, 2022 12:22

update examples folder to contain only examples instead of full .md c…

e32945d

…ontent

PR comment fix

bd0958c

BethanyZhou reviewed Mar 8, 2022

View reviewed changes

...lInsights/OperationalInsights.Autorest/examples/Get-AzOperationalInsightsDeletedWorkspace.md Outdated Show resolved Hide resolved

Update src/OperationalInsights/OperationalInsights.Autorest/examples/…

28a382a

…Get-AzOperationalInsightsDeletedWorkspace.md

BethanyZhou reviewed Mar 8, 2022

View reviewed changes

src/OperationalInsights/OperationalInsights.Autorest/examples/Get-AzOperationalInsightsTable.md Outdated Show resolved Hide resolved

...lInsights/OperationalInsights.Autorest/examples/Get-AzOperationalInsightsDeletedWorkspace.md Show resolved Hide resolved

BethanyZhou added 2 commits March 8, 2022 09:12

Update src/OperationalInsights/OperationalInsights.Autorest/examples/…

59226cc

…Get-AzOperationalInsightsDeletedWorkspace.md

Update Get-AzOperationalInsightsDeletedWorkspace.md

b031475

dabenhamMic added 2 commits March 8, 2022 10:25

changed examples format

3ea167d

pr comment fixes

426a3c2

BethanyZhou reviewed Mar 9, 2022

View reviewed changes

src/OperationalInsights/OperationalInsights.Autorest/examples/Get-AzOperationalInsightsTable.md Show resolved Hide resolved

pr comments

195727b

BethanyZhou reviewed Mar 9, 2022

View reviewed changes

dabenhamMic added 2 commits March 13, 2022 14:44

added description to New-AzOperationalInsightsWorkspace and Remove-Az…

e7aeb4c

…OperationalInsightsTable cmdltes

pr comments

fce8a5e

BethanyZhou approved these changes Mar 14, 2022

View reviewed changes

BethanyZhou merged commit cfc0509 into Azure:generation Mar 14, 2022

[OperationalInsights] onboarding autorest - Create hybrid repo #16903

[OperationalInsights] onboarding autorest - Create hybrid repo #16903

Uh oh!

Conversation

dabenhamMic commented Jan 24, 2022

Description

Checklist

Uh oh!

dabenhamMic commented Jan 24, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LucasYao93 commented Jan 25, 2022

Uh oh!

dabenhamMic commented Jan 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

LucasYao93 commented Feb 10, 2022

Uh oh!

dabenhamMic commented Feb 13, 2022 • edited by LucasYao93 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dabenhamMic commented Mar 7, 2022

Uh oh!

BethanyZhou commented Mar 7, 2022

Uh oh!

azure-pipelines bot commented Mar 7, 2022

Uh oh!

Uh oh!

BethanyZhou commented Mar 7, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BethanyZhou commented Mar 8, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BethanyZhou commented Mar 14, 2022

Uh oh!

azure-pipelines bot commented Mar 14, 2022

Uh oh!

BethanyZhou left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dabenhamMic commented Jan 31, 2022 •

edited

Loading

dabenhamMic commented Feb 13, 2022 •

edited by LucasYao93

Loading