-
Notifications
You must be signed in to change notification settings - Fork 462
Clean up Help action CLI for pack command with refactored argument parsing and ConsoleApp help routing #4639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: aishwaryabh <[email protected]>
Co-authored-by: aishwaryabh <[email protected]>
… present Changed the condition in PackAction.ParseArgs() to only throw CliArgumentsException when args contain --help, -h, or -? flags, instead of when no args are provided. This ensures the help display behavior only triggers when explicitly requested. Addresses feedback from @aishwaryabh in comment 2342407401. Co-authored-by: aishwaryabh <[email protected]>
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…proach Co-authored-by: aishwaryabh <[email protected]>
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
@copilot can you update ConsoleApp so that if I pass in any action (such as |
…ssed to specific actions Co-authored-by: aishwaryabh <[email protected]>
I've updated the ConsoleApp to properly handle help flags when passed to specific actions like The key changes:
Now Commit: 808ccd8 Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR implements comprehensive improvements to the help display for the
func pack
command to provide better user experience and clearer documentation.Changes Made
Pack Action Visibility
ShowInHelp = false
toShowInHelp = true
inPackAction.cs
so the pack command now appears in general help outputEnhanced General Help (
func --help
)The pack action now displays in the expected format:
Action-Specific Help (
func pack --help
)Completely enhanced the
DisplayActionHelp()
method inHelpAction.cs
to show comprehensive help including:func pack [arguments] [options]
<PROJECT | SOLUTION>
with proper description--output
and--no-build
✅ REFACTORED: Positional Arguments Architecture
GetPositionalArguments()
virtual method that actions can override to declare their positional argumentsGetPositionalArguments()
method instead of relying on exceptions✅ NEW: ConsoleApp Help Routing
--help
,-h
,-?
) are passed with specific actions, the system now shows action-specific help instead of general helpfunc --help
,func help
) continue to work as beforefunc pack --help
now show comprehensive pack-specific documentationTesting
HelpActionTests.cs
to validate the new help formatExample Output
When users run
func pack --help
, they will see:This provides users with clear, comprehensive documentation about how to use the pack command and its available options.
Fixes #4632.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.