chore: fix multi-eoa flake #16616
Merged
chore: fix multi-eoa flake #16616
+41
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexghr
commented
Aug 27, 2025
Comment on lines
+132
to
+120
| // NOTE: we only need to spy on a single client because all l1Utils use the same ViemClient instance | ||
| const originalSendRawTransaction = l1Utils[expectedFirstSender].client.sendRawTransaction; |
There was a problem hiding this comment.
This test will start breaking if the above 'note' is no longer true. It should be easy to fix then: just use two different spies!
alexghr
force-pushed
the
ag/fix-multi-eoa-flake
branch
from
71a76fa to
493d43a
Compare
spalladino
approved these changes
Aug 28, 2025
Comment on lines
+122
to
+123
| // auto-dispose of this spy at the end of this function | ||
| using _ = jest |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.