chore: audit wnaf relations in the ECCVM #16573
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notnotraju
commented
Aug 25, 2025
| @@ -18,17 +18,18 @@ namespace bb { | |||
| * | point_transition | round | slices | skew | scalar_sum | | |||
| * | ---------------- | ----- | --------------- | ------ | ------------------------------- | | |||
| * | 0 | 0 | s0,s1,s2,s3 | 0 | 0 | | |||
| * | 0 | 1 | s4,s5,s6,s7 | 0 | \sum_{i=0}^4 16^i * s_{31 - i} | | |||
There was a problem hiding this comment.
formulas were wrong
notnotraju
commented
Aug 25, 2025
| @@ -173,17 +181,19 @@ void ECCVMWnafRelationImpl<FF>::accumulate(ContainerOverSubrelations& accumulato | |||
| // => q_transition * (round - 7 - round_shift + round + 1) + (round_shift - round - 1) | |||
| // => q_transition * (2 * round - round_shift - 6) + (round_shift - round - 1) | |||
| const auto round_check = round_shift - round - 1; | |||
| std::get<9>(accumulator) += precompute_select * scaled_transition * ((round - round_check - 7) + round_check); | |||
There was a problem hiding this comment.
this only checks scaled_transition != 0 implies that round == 7, corrected below to also check the increment if scaled_transition == 0.
…g is kosher. still not completely sure.
notnotraju
added
the
bberg-int-audit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wNAF relations is more-or-less completely audited, modulo the multiset equality stuff that happens in
set_relation. This will also require fixing the docs in this file to actually accurately reflect what is being multiset-checked and why this is sufficient to (1) correctly constrainq_transitionandround.