Skip to content

Clarify serializer usage #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
3 commits merged into from
May 30, 2022
Merged

Clarify serializer usage #262

3 commits merged into from
May 30, 2022

Conversation

@ghost
Copy link

@ghost ghost commented May 30, 2022

closes #254

@ghost ghost requested review from CodeDrivenMitch, bruceaxoniq, gklijs and smcvb May 30, 2022 09:06
@ghost ghost self-assigned this May 30, 2022
@ghost ghost changed the base branch from 4.3 to 4.5 May 30, 2022 09:06
@ghost ghost linked an issue May 30, 2022 that may be closed by this pull request
Clarify serializers usage #254
Open
gklijs
gklijs approved these changes May 30, 2022
View reviewed changes
Copy link

@gklijs gklijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@smcvb smcvb added this to the Release 4.5 milestone May 30, 2022
smcvb
smcvb approved these changes May 30, 2022
View reviewed changes
Copy link
Collaborator

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion on the response type bit. Otherwise this looks good to me.

CodeDrivenMitch
CodeDrivenMitch approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@CodeDrivenMitch CodeDrivenMitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ghost ghost merged commit 199c501 into 4.5 May 30, 2022
@ghost ghost deleted the clarify-serializer-usage branch May 30, 2022 14:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruceaxoniq bruceaxoniq Awaiting requested review from bruceaxoniq

Assignees

No one assigned

Labels

Priority 2: Should Status: Resolved Type: Enhancement

Projects

None yet

Milestone

Release 4.5

Development

Successfully merging this pull request may close these issues.

Clarify serializers usage

3 participants

@gklijs @CodeDrivenMitch @smcvb