Skip to content

Conversation

@obenland
Copy link
Member

@obenland obenland commented Sep 18, 2025

See https://wordpress.org/support/topic/make-follow-reply-button-form-easier-for-users/#post-18620743

Proposed changes:

  • Update error messages in follow-me and remote-reply blocks to specify "WebFinger handle" instead of just "handle"
  • Change invalidProfileError message from "valid profile URL or handle" to "valid profile URL or WebFinger handle"
  • Applies to both src and build directories

Other information:

  • Have you written new tests for your changes, if applicable?

This change addresses user feedback from WordPress.org support forum requesting clearer guidance about the expected input format.

Testing instructions:

  • Go to a post with ActivityPub follow-me or remote-reply blocks enabled
  • Try to enter an invalid handle format (e.g., just "mastodon.social")
  • Verify the error message now shows "Please enter a valid profile URL or WebFinger handle" instead of the previous generic "handle" text
  • Confirm this appears in both follow-me and remote-reply block error states

Changelog entry

  • Automatically create a changelog entry from the details below.
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Added - for new features
  • Changed - for changes in existing functionality
  • Deprecated - for soon-to-be removed features
  • Removed - for now removed features
  • Fixed - for any bug fixes
  • Security - in case of vulnerabilities

Message

Clarify error messages by specifying WebFinger handle format for better user guidance

Update error text from "handle" to "WebFinger handle" to provide users
with clearer guidance about the expected format (@user@server.com).

Addresses user feedback from WordPress.org support forum requesting
more specific guidance for follow/reply form inputs.
Copilot AI review requested due to automatic review settings September 18, 2025 15:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves user experience by clarifying error messages to specify "WebFinger handle" instead of the generic "handle" in ActivityPub blocks. The change addresses user feedback requesting clearer guidance about expected input formats.

  • Updated error messages in follow-me and remote-reply blocks to be more specific
  • Changed "Please enter a valid URL or handle" to "Please enter a valid profile URL or WebFinger handle"
  • Applied changes consistently across both src and build directories

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/remote-reply/render.php Updated invalidProfileError message to specify WebFinger handle format
src/follow-me/render.php Updated invalidProfileError message to specify WebFinger handle format
build/remote-reply/render.php Updated invalidProfileError message to specify WebFinger handle format
build/follow-me/render.php Updated invalidProfileError message to specify WebFinger handle format

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added [Block] Follow Me [Block] Remote Reply aka "Reply on the Fediverse", in the comment list [Focus] Editor Changes to the ActivityPub experience in the block editor labels Sep 18, 2025
@obenland obenland self-assigned this Sep 18, 2025
@obenland obenland requested a review from pfefferle September 18, 2025 15:06
@pfefferle
Copy link
Member

Is "WebFinger" something a regular user understands? I would assume not!?

@obenland
Copy link
Member Author

What would you suggest?

@pfefferle
Copy link
Member

I actually like "handle"... or "email like" handle?

Have you tried to ask chatgpt?

@obenland
Copy link
Member Author

Please enter a valid profile URL or use the @username@server format.

We do show @[email protected] as the placeholder in that input field.

@pfefferle
Copy link
Member

Yes, we do!

obenland and others added 4 commits September 18, 2025 13:16
Co-authored-by: Matthias Pfefferle <[email protected]>
Co-authored-by: Matthias Pfefferle <[email protected]>
Co-authored-by: Matthias Pfefferle <[email protected]>
Co-authored-by: Matthias Pfefferle <[email protected]>
@obenland obenland requested a review from pfefferle September 18, 2025 18:16
pfefferle
pfefferle previously approved these changes Sep 18, 2025
Copy link
Member

@pfefferle pfefferle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the changelog text.

Update error messages to specify the required full profile URL format, improving user guidance in the account modal.
@obenland obenland merged commit d150715 into trunk Sep 18, 2025
13 checks passed
@obenland obenland deleted the update/error-text branch September 18, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Follow Me [Block] Remote Reply aka "Reply on the Fediverse", in the comment list [Focus] Editor Changes to the ActivityPub experience in the block editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants