-
Notifications
You must be signed in to change notification settings - Fork 83
Clarify error messages by specifying WebFinger handle format #2209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update error text from "handle" to "WebFinger handle" to provide users with clearer guidance about the expected format (@user@server.com). Addresses user feedback from WordPress.org support forum requesting more specific guidance for follow/reply form inputs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves user experience by clarifying error messages to specify "WebFinger handle" instead of the generic "handle" in ActivityPub blocks. The change addresses user feedback requesting clearer guidance about expected input formats.
- Updated error messages in follow-me and remote-reply blocks to be more specific
- Changed "Please enter a valid URL or handle" to "Please enter a valid profile URL or WebFinger handle"
- Applied changes consistently across both src and build directories
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/remote-reply/render.php | Updated invalidProfileError message to specify WebFinger handle format |
| src/follow-me/render.php | Updated invalidProfileError message to specify WebFinger handle format |
| build/remote-reply/render.php | Updated invalidProfileError message to specify WebFinger handle format |
| build/follow-me/render.php | Updated invalidProfileError message to specify WebFinger handle format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Is "WebFinger" something a regular user understands? I would assume not!? |
|
What would you suggest? |
|
I actually like "handle"... or "email like" handle? Have you tried to ask chatgpt? |
We do show |
|
Yes, we do! |
Co-authored-by: Matthias Pfefferle <[email protected]>
Co-authored-by: Matthias Pfefferle <[email protected]>
Co-authored-by: Matthias Pfefferle <[email protected]>
Co-authored-by: Matthias Pfefferle <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the changelog text.
Update error messages to specify the required full profile URL format, improving user guidance in the account modal.
See https://wordpress.org/support/topic/make-follow-reply-button-form-easier-for-users/#post-18620743
Proposed changes:
invalidProfileErrormessage from "valid profile URL or handle" to "valid profile URL or WebFinger handle"Other information:
This change addresses user feedback from WordPress.org support forum requesting clearer guidance about the expected input format.
Testing instructions:
Changelog entry
Changelog Entry Details
Significance
Type
Message
Clarify error messages by specifying WebFinger handle format for better user guidance