Update ActivityPub context and rename implemented specs property #2068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the FEP 844e context URL and added an 'implements' property to the ActivityPub context for listing implemented specifications. Renamed the protected property from 'implemented' to 'implements' to align with the updated context and documentation reference.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ActivityPub context to properly implement FEP 844e specification for listing implemented specifications. The changes remove the FEP 844e context URL from the global context and add an 'implements' property definition, while also renaming the corresponding property and updating documentation references.
- Removed FEP 844e context URL from global context array
- Added 'implements' property definition to the ActivityPub context with proper JSON-LD structure
- Renamed protected property from 'implemented' to 'implements' and updated documentation reference
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| includes/activity/class-actor.php | Updated ActivityPub context structure and property naming for FEP 844e implementation |
| .github/changelog/2068-from-description | Added changelog entry documenting the FEP 844e fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the FEP 844e context URL and added an 'implements' property to the ActivityPub context for listing implemented specifications. Renamed the protected property from 'implemented' to 'implements' to align with the updated context and documentation reference.
Proposed changes:
Other information:
Testing instructions:
Changelog entry
Changelog Entry Details
Significance
Type
Message
Proper implementation of FEP 844e.