Improve summary generation #2063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added is_actor() check before filtering activity summaries in Hashtag and Link classes to ensure correct processing. Updated generate_post_summary to return plain content instead of applying 'the_excerpt' filter, due to lack of proper HTML support in ActivityPub summaries.
pfefferle
requested review from
Copilot and
obenland
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR fixes ActivityPub summary generation and filtering by removing HTML content from summaries and adding proper actor validation. The main purpose is to improve compatibility by switching to plain text summaries and ensuring filtering only applies to actor activities.
- Removes HTML from post summaries by bypassing the
the_excerptfilter - Adds
is_actor()validation before applying content filtering in Hashtag and Link classes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| includes/functions.php | Updates generate_post_summary to return plain content instead of filtered HTML |
| includes/class-link.php | Adds actor validation before processing activity summaries |
| includes/class-hashtag.php | Adds actor validation before processing activity summaries |
pfefferle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added is_actor() check before filtering activity summaries in Hashtag and Link classes to ensure correct processing. Updated generate_post_summary to return plain content instead of applying 'the_excerpt' filter, due to lack of proper HTML support in ActivityPub summaries.
Revert 170bab3
Fixes #2059 #2062
Proposed changes:
the_excerptfilteris_actor()validation before applying content filtering in Hashtag and Link classesOther information:
Testing instructions:
Changelog entry
Changelog Entry Details
Significance
Type
Message
Switches ActivityPub summaries to plain text for better compatibility.