Handle errors in actor retrieval for followers/following #2055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap actor retrieval in is_wp_error checks in both Followers_Controller and Following_Controller to prevent invalid actors from being included in orderedItems. Uses array_filter to remove any failed lookups, improving robustness of REST responses.
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling in the followers and following REST API endpoints by preventing invalid actors from appearing in the response. The change wraps actor retrieval calls with error checking to handle cases where Actors::get_actor() returns a WP_Error object.
Key changes:
- Added error checking for actor retrieval in both controllers
- Used
array_filterto remove failed actor lookups from the response - Maintained consistent behavior across followers and following endpoints
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| includes/rest/class-followers-controller.php | Added error handling to filter out invalid actors from followers list |
| includes/rest/class-following-controller.php | Added error handling to filter out invalid actors from following list |
Co-authored-by: Copilot <[email protected]>
Replaces unqualified calls to array_map and is_wp_error with their fully qualified counterparts (\array_map, \is_wp_error) in Followers_Controller and Following_Controller. This change improves code clarity and prevents potential issues with function overrides or namespace conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap actor retrieval in is_wp_error checks in both Followers_Controller and Following_Controller to prevent invalid actors from being included in orderedItems. Uses array_filter to remove any failed lookups, improving robustness of REST responses.
Related #2053
Proposed changes:
Other information:
Testing instructions:
Changelog entry
Changelog Entry Details
Significance
Type
Message
Improves REST responses by skipping invalid actors in Followers and Following controllers.