-
Notifications
You must be signed in to change notification settings - Fork 84
Starter Kit: Interaction API #2049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a UI for selecting which accounts to follow during the Starter Kit import process. Refactors import logic to process only selected actors, adds error handling for file reading and JSON parsing, and improves feedback for follow actions.
Changed the heading text to clarify that the author selection is for the imported Starter Kit, improving user guidance during the import process.
Modularizes the import options method by splitting UI rendering and filter setup/cleanup into dedicated private methods. Improves error handling, form structure, and actor validation for better maintainability and clarity.
Added @param annotations to the render_error and render_import_form methods in Starter_Kit to improve code documentation and clarify expected argument types.
Introduces the ability to import Starter Kits from a remote URL in addition to file uploads. Adds a new form for URL input, handles validation, fetches and saves JSON data, and updates the import step logic to support this workflow.
Replaces null coalescing with an explicit isset check for the 'url' GET parameter to prevent undefined index notices. Also prefixes all printf calls with a backslash for consistency.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Introduces a dedicated static property for the blog user filter callback and updates its assignment. Adds missing global namespace prefixes to WordPress and PHP functions for consistency. Improves code readability and maintainability.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Added a PHPCS ignore comment to suppress missing nonce verification warning in the handle_url_import method. This change is intended to bypass the WordPress.Security.NonceVerification.Missing rule for this specific line.
Co-authored-by: Copilot <[email protected]>
Prefixed is_wp_error with a backslash to ensure the global function is called, preventing potential issues with namespacing in attachment insertion error handling.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Aligned variable assignments for better readability in the Starter_Kit class within the import module. No functional changes were made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for handling Starter Kit collections through the ActivityPub Interaction API by introducing new case handlers for collection-type objects and improving code consistency.
- Adds handling for Collection, CollectionPage, OrderedCollection, and OrderedCollectionPage object types
- Updates existing code to use consistent function calling patterns by removing unnecessary
boolval()wrapper - Introduces a new filter hook for customizing Starter Kit import URLs
Comments suppressed due to low confidence (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for handling Starter Kit collections through the ActivityPub Interaction API by introducing new case handlers for collection-type objects and modifying existing logic for better consistency.
For more context see:
Proposed changes:
Other information:
Testing instructions:
Changelog entry
Changelog Entry Details
Significance
Type
Message
Adds support for Starter Kit collections in the ActivityPub API.