Skip to content

Conversation

@obenland
Copy link
Member

@obenland obenland commented Jul 31, 2025

Fixes #2037.

Proposed changes:

  • Updated the import logic to consistently treat items as actor IDs, ensuring they are strings and valid URLs before attempting to follow.

Demo files:

starter-kit.json (actor objects)
starter-kit-2.json (list of actor ids and webfingers)

Changelog entry

  • Automatically create a changelog entry from the details below.
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Added - for new features
  • Changed - for changes in existing functionality
  • Deprecated - for soon-to-be removed features
  • Removed - for now removed features
  • Fixed - for any bug fixes
  • Security - in case of vulnerabilities

Message

Added support for list of Actor IDs in Starter Kits.

Updated the import logic to consistently treat items as actor IDs, ensuring they are strings and valid URLs before attempting to follow.
@obenland obenland requested a review from pfefferle July 31, 2025 18:09
@obenland obenland self-assigned this Jul 31, 2025
Copilot AI review requested due to automatic review settings July 31, 2025 18:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the starter kit import logic to support a list of actor IDs by treating all items consistently as actor IDs. The change improves the handling of different input formats (strings vs objects) and adds URL validation before attempting to follow actors.

  • Updated variable naming from $item to $actor_id for clarity
  • Added string conversion and URL validation for actor IDs
  • Simplified the follow operation by using the actor ID directly

@obenland obenland merged commit 223710a into trunk Jul 31, 2025
12 checks passed
@obenland obenland deleted the add/id-support branch July 31, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Support for importing non-inlined starter kits

4 participants